04-02-2004 19:50	edit | quote	#1 | report |
DESIGN/PROJECT: GovernmentsModified complete Support Apolyton, buy GURPS/ Alpha Centauri

code:

IMPROVE_COURTHOUSE {
   DefaultIcon ICON_IMPROVE_COURTHOUSE
   Description DESCRIPTION_IMPROVE_COURTHOUSE
   EnableAdvance ADVANCE_JURISPRUDENCE
   ProductionCost 330
   Upkeep 1
   LowerCrime -0.1
}

code:

IMPROVE_COURTHOUSE {
   DefaultIcon ICON_IMPROVE_COURTHOUSE
   Description DESCRIPTION_IMPROVE_COURTHOUSE
   EnableAdvance ADVANCE_JURISPRUDENCE
   ProductionCost 330
   Upkeep 1
   LowerCrime -0.1
}

IMPROVE_COURTHOUSE > GOVERNMENT_MONARCHY {
   DefaultIcon ICON_IMPROVE_COURTHOUSE
   Description DESCRIPTION_IMPROVE_COURTHOUSE
   EnableAdvance ADVANCE_JURISPRUDENCE
   ProductionCost 330
   Upkeep 3
   LowerCrime -0.3
   HappyInc -1
}

code:
IMPROVE_COURTHOUSE > DecreasedCrime_and_Happy_HarshGovs , 
GOVERNMENT_MONARCHY, GOVERNMENT_THEOCRACY {

code:

IMPROVE_COURTHOUSE {
   DefaultIcon ICON_IMPROVE_COURTHOUSE
   Description DESCRIPTION_IMPROVE_COURTHOUSE
   EnableAdvance ADVANCE_JURISPRUDENCE
   ProductionCost 330
   Upkeep 1
   LowerCrime -0.1
}

IMPROVE_COURTHOUSE > Monarchy {
   DefaultIcon ICON_IMPROVE_COURTHOUSE
   Description DESCRIPTION_IMPROVE_COURTHOUSE
   EnableAdvance ADVANCE_JURISPRUDENCE
   GovernmentsModified GOVERNMENT_MONARCHY
   ProductionCost 330
   Upkeep 3
   LowerCrime -0.3
   HappyInc -1
}

code:

template  const T *CTPDatabase::Get(sint32 index,sint32 govIndex)
    and
template  T *CTPDatabase::Access(sint32 index,sint32 govIndex)

code:

template  const T *CTPDatabase::Get(sint32 index)
    and
template  T *CTPDatabase::Access(sint32 index)

Notice the extra govIndex parameter. These are overloaded functions, so the existing functions can still be used.

Work we (or maybe just I ) need to do

None of the existing record access in the code (1700 hundred instances of ->Get( and ->Access(, not all of which are applicable,) use the new method... so they need to be changed...

This, however, isn't complicated... just a lot of repetition.

Here's an example of a couple of changes, that I used to test that the system was working fine...

code:

Original (from CityData::CanBuildBuilding):

const BuildingRecord* irec = g_theBuildingDB->Get(type);

New:

const BuildingRecord* irec = g_theBuildingDB->Get(type,g_player[m_owner]->GetGovernmentType());

and, from CityData::CanBuildUnit

const UnitRecord *rec = g_theUnitDB->Get(type);

becomes

	const UnitRecord *rec = g_theUnitDB->Get(type,g_player[m_owner]->GetGovernmentType());

Last edited by MrBaggins on 06-02-2004 at 20:07

21-02-2004 19:55	edit | quote	#4 | report |
Support Apolyton, buy Call to Power 2

Last edited by MrBaggins on 21-02-2004 at 20:10

30-04-2004 22:30 | www	edit | quote	#5 | report |
Enter the AD-FREE zone

code:

/*	sint32* m_recordsModifiedLink;
	sint32 m_numRecordsModifiedLink;
	sint32 m_allocatedRecordsModifiedLinkSize;

	sint32* m_modList;
	sint32 m_numModList;
	sint32 m_allocatedListSize;*/

11-08-2008 03:30 | www	edit | quote	#21 | report |
Support Apolyton buy from Amazon

code:
template  T *CTPDatabase::Access(sint32 index)
{
	Assert(index >= 0);
	Assert(index < m_numRecords);
	if((index < 0) || (index >= m_numRecords))
	{
		DPRINTF(k_DBG_GAMESTATE, ("CTPDatabase::Access: index: %i, numRecords: %i\n", index, m_numRecords));
		return NULL;
	}

	return m_records[index];
}

so the modified tyranny warrior index is not less than m_numRecords, but what do I do about it?